Merged
Conversation
…stead of a custom color.
…match cycle logic from EmphasisManager to FindViewController. Using EmphasisManager in bracket pair matching instead of custom implementation reducing duplicated code. Implemented flash find matches when clicking the next and previous buttons when the editor is in focus. `bracketPairHighlight` becomes `bracketPairEmphasis`. Fixed various find issues and cleaned up implementation.
6 tasks
thecoolwinter
requested changes
Mar 31, 2025
Sources/CodeEditTextView/TextSelectionManager/TextSelectionManager.swift
Show resolved
Hide resolved
…odeEditTextView into feat/in-doc-search
thecoolwinter
approved these changes
Apr 6, 2025
Contributor
Author
|
Merging, @tom-ludwig previously approved. |
This was referenced Apr 8, 2025
Closed
thecoolwinter
added a commit
to CodeEditApp/CodeEditSourceEditor
that referenced
this pull request
Apr 8, 2025
> [!IMPORTANT] > ~~We need to merge CodeEditApp/CodeEditTextView#78 before merging this PR.~~ ### Description This PR introduces the initial implementation of the “Find in Editor” feature for the source editor. Users can now search for text within the currently open file using ⌘ F. All matching results are visually emphasized, and users can navigate between matches using next/previous controls. What’s Included - Text search across the current document - Match highlighting with emphasis on the currently selected match - Keyboard shortcut support: ⌘ F to activate the find bar - Looping navigation with HUD notifications: - Reaching the end → loops to first result (arrow.triangle.capsulepath) - Reaching the beginning → loops to last result (flipped arrow.triangle.capsulepath) - No more matches → arrow.down.to.line HUD icon displayed ### Related Issues - CodeEditApp/CodeEditTextView#1 - closes CodeEditApp/CodeEditTextView#3 - CodeEditApp/CodeEditTextView#78 * #ISSUE_NUMBER ### Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots <!--- REQUIRED: if issue is UI related --> <!--- IMPORTANT: Fill out all required fields. Otherwise we might close this PR temporarily --> --------- Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed EmphasizeAPI to EmphasisManager. It now supports various emphasis styles including standard highlights, underlines, and outlines, with optional behaviors such as flashing, selection, and inactive styling.
Key Features:
This enables visual feedback for features like search highlights, bracket pair emphasis, and other temporary visual cues in the editor.
Related Issues
Checklist
Screenshots